Skip to content

Enabling the AsciiDoc map Vale rules in the CI - #118871

Merged
bergerhoffer merged 1 commit into
openshift:mainfrom
bergerhoffer:enabling-map-rules
Aug 26, 2026
Merged

Enabling the AsciiDoc map Vale rules in the CI#118871
bergerhoffer merged 1 commit into
openshift:mainfrom
bergerhoffer:enabling-map-rules

Conversation

@bergerhoffer

@bergerhoffer bergerhoffer commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Version(s):
4.20+

Issue:
N/A

Link to docs preview:
N/A

QE review:
N/A

Additional information:

Enables the new Map* rules for validating AsciiDoc DITA maps: https://redhat.atlassian.net/wiki/spaces/OSDOCS/pages/265912624/Content+updates+in+preparation+for+migrating+to+DITA

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 25, 2026
@bergerhoffer bergerhoffer changed the title Emabling the AsciiDoc map Vale rules in the CI Enabling the AsciiDoc map Vale rules in the CI Aug 25, 2026
@bergerhoffer bergerhoffer added this to the Continuous Release milestone Aug 25, 2026
@ocpdocs-previewbot

ocpdocs-previewbot commented Aug 25, 2026

Copy link
Copy Markdown

🤖 Tue Aug 25 20:33:18 - Prow CI generated the docs preview:

https://118871--ocpdocs-pr.netlify.app/

@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown

@bergerhoffer: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@bergerhoffer

bergerhoffer commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

@bscott-rh @ShaunaDiaz Could one of you please review? This is to enable the new Map* AsciiDocDITA rules: https://github.com/jhradilek/asciidoctor-dita-vale#available-rules

@bscott-rh

bscott-rh commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

@bscott-rh @ShaunaDiaz Could one of you please review? This is to enable the new Map* AsciiDocDITA rules: https://github.com/jhradilek/asciidoctor-dita-vale#available-rules

Rules LGTM.

ShaunaDiaz
ShaunaDiaz reviewed Aug 26, 2026
View reviewed changes

@ShaunaDiaz ShaunaDiaz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2026
@bergerhoffer
bergerhoffer merged commit 8e3a5df into openshift:main Aug 26, 2026
2 checks passed
@bergerhoffer

bergerhoffer commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-5.0

@bergerhoffer

bergerhoffer commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.22

@bergerhoffer

bergerhoffer commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.21

@bergerhoffer

bergerhoffer commented Aug 26, 2026

Copy link
Copy Markdown
Contributor Author

/cherrypick enterprise-4.20

@openshift-cherrypick-robot

openshift-cherrypick-robot commented Aug 26, 2026

Copy link
Copy Markdown

@bergerhoffer: #118871 failed to apply on top of branch "enterprise-5.0":

Applying: Enabling the AsciiDoc map Vale rules in the CI
Using index info to reconstruct a base tree...
M	.vale.ini
Falling back to patching base and 3-way merge...
Auto-merging .vale.ini
CONFLICT (content): Merge conflict in .vale.ini
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Enabling the AsciiDoc map Vale rules in the CI
Details

In response to this:

/cherrypick enterprise-5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

openshift-cherrypick-robot commented Aug 26, 2026

Copy link
Copy Markdown

@bergerhoffer: #118871 failed to apply on top of branch "enterprise-4.22":

Applying: Enabling the AsciiDoc map Vale rules in the CI
Using index info to reconstruct a base tree...
M	.vale.ini
Falling back to patching base and 3-way merge...
Auto-merging .vale.ini
CONFLICT (content): Merge conflict in .vale.ini
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Enabling the AsciiDoc map Vale rules in the CI
Details

In response to this:

/cherrypick enterprise-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

openshift-cherrypick-robot commented Aug 26, 2026

Copy link
Copy Markdown

@bergerhoffer: #118871 failed to apply on top of branch "enterprise-4.21":

Applying: Enabling the AsciiDoc map Vale rules in the CI
Using index info to reconstruct a base tree...
M	.vale.ini
Falling back to patching base and 3-way merge...
Auto-merging .vale.ini
CONFLICT (content): Merge conflict in .vale.ini
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Enabling the AsciiDoc map Vale rules in the CI
Details

In response to this:

/cherrypick enterprise-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot

openshift-cherrypick-robot commented Aug 26, 2026

Copy link
Copy Markdown

@bergerhoffer: #118871 failed to apply on top of branch "enterprise-4.20":

Applying: Enabling the AsciiDoc map Vale rules in the CI
Using index info to reconstruct a base tree...
M	.vale.ini
Falling back to patching base and 3-way merge...
Auto-merging .vale.ini
CONFLICT (content): Merge conflict in .vale.ini
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Enabling the AsciiDoc map Vale rules in the CI
Details

In response to this:

/cherrypick enterprise-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Aug 26, 2026
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShaunaDiaz ShaunaDiaz ShaunaDiaz left review comments

Assignees

@ShaunaDiaz ShaunaDiaz

Labels

branch/enterprise-4.20 branch/enterprise-4.21 branch/enterprise-4.22 branch/enterprise-5.0 lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

5 participants

@bergerhoffer @ocpdocs-previewbot @bscott-rh @openshift-cherrypick-robot @ShaunaDiaz